-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Scipy2013 Sprint: Cleaning examples of api example #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import numpy as np | ||
|
||
fig, ax1 = plt.subplots() # ax1 is the Fahrenheit scale | ||
ax2 = ax1.twinx() # ax2 is the Celsius scale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really Minor: Maybe move figure/axes definitions down with the rest of the plotting code (i.e. below the function defs). Also, I think the inline comments should be removed here. (Maybe ax1
-> ax_f
, ax2
-> ax_c
?)
Thanks for cleaning up some examples! I think the fahrenheit/celsius scale example is more or less ready to go. (I had some minor comments, but nothing major.) The barchart examples may need a bit more thought. The original example showed a few more features than just error bars. I'd be inclined to split the example up into As suggested in the MEP12 guidelines, you need to check whether the examples you move are referenced in the docs. I believe |
Yeah. Your suggestion seems more reasonable on the farenheit/celsius plot. So there is already a cleaned version of the barchart? I will check. And also will check about the backend_driver. |
@tonysyu, just changed the F/C plot. The other is still pending. |
@gabraganca What is the state of this? |
Seems to have install issues with py3 and unicode strings. |
I had totally forgot about this. |
Since it has been a long time that I do not work on this, what would you recommend? I should do a rebase and then let the Travis check again? |
It looks like the F/C demo is good, but the barchart demo still needs some thought/merging with How about pulling the F/C demo changes out into a new PR which we can get merged straight away and, unless you are willing to put more time into cleaning up the barchart demo, dropping that part? |
Ok. I will do this now. |
Worked on two examples.