Skip to content

DEV: Decide if pre-commit should continue to be used #22949

Closed
@matthewfeickert

Description

@matthewfeickert

OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only application with similar access.

Originally posted by @tacaswell in #22777 (comment)

@tacaswell turned on pre-commit.ci for PR #22777

pre-commit.ci status

following discussions in PR #22809, PR #22777, and on Gitter.

There was not a clear consensus if the dev team was comfortable with another service that has push permissions like those shown in matthewfeickert#9 being connected to the matplotlib/matplotlib repo and if the examples shown in matthewfeickert#12 provided information that was acceptable.

Given #22777 (comment)

I'm in favor of getting this running on CI in any way that marks with a red-x, merging this, and then iterating on how best to notify at what needs to be changed.

pre-commit.ci was turned on, but the dev team should decide if they are happy with it or not. If they are happy with it, I am willing to help answer any questions they have in the future on it and make demo PRs on my forks of any situations they might be concerned with. If they are not happy, I am willing to help implement a solution that is acceptable to them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions