-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[MNT]: Slowly move towards pyproject.toml? #23815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am in favour of this. The FWIW Bokeh has just made this transition. |
I gave it a quick try to just move over the more basic things and got stuck in that Copying the contents doesn't seem like the best way to solve it... |
A temporary environment is used to build a wheel which is then installed into your working environment. The temporary environment doesn't seem to have access to the full project directory. I have had success with:
so basically botching the |
I've seen some problems with numpy versions. My guess is that using pyproject.toml somehow uses a different version of NumPy headers than possibly installed. For example, when installing using 1.22 installed I got an error about not matching API versions, which I didn't get with a plain setup.py install, while upgrading to 1.23 (and reinstalling, so not completely sure) I didn't. Seen similar problems with another package with a much simpler install procedure as well. Note that in both cases, the actual compilation happened in setup.py, so moving all the way may be a solution. |
@oscargus See https://github.com/matplotlib/matplotlib/pull/23829/files#r968896893 for the numpy API version issue. |
This was completed as part of the Meson port in #26621. |
Summary
I was considering moving parts of setup.py and setup.cfg to pyproject.toml. As I understand it, it is possible to mix and match, so whatever can be moved (I can move) will cooperate with what is left.
Since we have a setup.py with a bit of magic in it, I do no expect that I will be able to completely transition, but is it worthwhile even starting? Or do we expect that moving away from setup.py (which I guess should be the long term goal) requires more or less rewriting everything anyway, possibly changing packaging tool etc?
Proposed fix
No response
The text was updated successfully, but these errors were encountered: