-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[ENH]: Set color of legend shadow #24663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was thinking of reviving the linked PR, but I saw something that confused me a bit. More generally, in test_rcparams.py, there are some expressions (under
Is there a principled way to check if a
good enough? |
I believe that one should differentiate between the rcparams and passing the argument to For rcparams there will indeed be a bit of a clash for For I think the current code deals with it quite OK, but one should probably document the possible clashes somewhere and how it behaves. |
I think deprecating the interpretation of t/f/y/n as bools in rcparams would be reasonable too. |
is this issue still open? If yes I would like take it....... |
There is already some work done and discussion in the linked pull request. I was hoping to finish it next week but feel free to help if you'd like. |
Problem
There was a PR to set the shadow color for legend which is now closed: #18668
Proposed solution
Revive that PR. The fair thing to do is to add a Co-authored-by with the original author even if it looks like you will have to copy-and-paste the code. (If you rewrite it independently, there is of course no need to do that.)
Note that there are still some review comments left to handle.
The text was updated successfully, but these errors were encountered: