-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Clockwise pie diagram #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you add a regression test and a what's new entry? |
I think yes, if you give me a link to some tutorial. I am novice here and don't know what type of regression test you want, and what and where write about what's new (do you mean just add new input parameter in function comment?) Back compatibility seems obvious, if counterclock is True, new code works just like old one. |
@fat-crocodile Have you been able to work in this? It would be nice to get this into 1.4.0. |
Your english is too good for me, sorry, I can not understand precisely what are you asking for. This code works good in my project, diff looks quite simple. If I shall do something to help you include this code in 1.4.0, tell me please what shall I do. |
Do you know how to use git/github well enough to create a pull request? There is a file in the documentation folder If you can please make a pull request. If not then I will take care of this. |
Closing this in favor of the open PR (#2853) |
Hi! Please, add this feature. My diff in axes.py looks quite simple:
The text was updated successfully, but these errors were encountered: