Skip to content

[MNT]: CodeCov CarryForward Flags? #25391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rcomer opened this issue Mar 5, 2023 · 1 comment
Open

[MNT]: CodeCov CarryForward Flags? #25391

rcomer opened this issue Mar 5, 2023 · 1 comment
Labels
Maintenance

Comments

@rcomer
Copy link
Member

rcomer commented Mar 5, 2023

Summary

Recently we have been making more effort to not run all the tests when unnecessary, particularly for doc only changes (#25145, #25261, #25383). By default CodeCov seems to depend on the tests having been run on both current and previous commit in order to produce the report. If it has different numbers of test reports for the two commits, it fails, showing as "indirect changes" on a lot of files (example).

Proposed fix

This situation is described in the CodeCov docs (point 9 here), and CarryForward flags appear to be the recommended solution. I have not really understood the docs on CarryForward flags though.
@rcomer rcomer mentioned this issue Jun 4, 2023
Open
@oscargus
Copy link
Member

oscargus commented Jun 4, 2023

Seems like carry-forward flags can be used if nothing is tested in a file, but not for things like platform-dependent code? As parts of e.g. GTK4 is still covered, it is not clear if it will help us. Unless we can skip ALL tests for doc-builds(?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscargus @rcomer