-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
error checking should be performed as early as possible (here: non-ASCII str's in e.g. ylabel()) #2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ipython/ipython#3922 is related, but I would like to see this tackled in MPL, too. |
MEP13 is related to this. |
MEP13 is about using properties; I guess you meant MEP14 ("… improving the text handling …"): |
Nope -- by using properties as in MEP13, we will be performing error checking of values much earlier than we are now. |
I considered that interpretation, too, but properties would just be a syntactic change, no? I mean - the same check could be in the setter today?! If you want to introduce something like traits, that'd be something different, but MEP13 did not seem to discuss traits, but just the leaving-out-the-parentheses part? |
That's true -- I just meant to link this issue as one of many that we have that would benefit from more consistent use of setters/properties/traits. You're right that the underlying technology barely matters -- it's a matter of checking in a single place as early as possible. |
What's the exact action for MPL for this issue? |
I think we punted this to the traitlets work
…On Thu, Jan 5, 2017 at 11:05 PM, Pete Huang ***@***.***> wrote:
What's the exact action for MPL for this issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2560 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-NSjk8Zj-go-PCaKQKYYfCCkqzEuks5rPb2hgaJpZM4BJqYr>
.
|
For visitor reference, traitlets discussion/work sitting in #4762. Guess we can leave this open (...ugh) but need to remember to come back to this once traitlets work is complete |
set_ylabel raises an exception now
so closing (unless I'm mistaken?). The traitlets work is tracked in a number of other issues. |
When using set_ylabel('Täst') in the ipython notebook, there will not be any plot, but also no error message visible. The real problem is that the notebook does not show exceptions that happen in draw(), but also in the console ipython, an exception raised by set_ylabel() itself would be rendered much better than the one coming asynchroneously from draw().
If possible, an exception like this one:
should already be raised in the Text() constructor (or whereever appropriate).
The text was updated successfully, but these errors were encountered: