-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[MNT]: [ci doc]
doesn't skip Github tests.
#26693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That PR is the one that introduced the behavior to skip on I tested it in that PR by adding an empty commit and it didn't run gha (appveyor still ran, I believe) As far as I can tell, it worked for the most recent commit of #26669 (a84ab3d). Note that it does only take into account the most recent commit message, not all commits of the PR. Also, only the tests workflow is skipped, not all gha workflows, so linting/pr cleanliness, mypy, etc still do run, but those are all pretty quick checks. |
Quoting myself from #25383 (comment)
|
Hmmm.... I mean just looking at #26669, that does not show the tests as having run for the PR status checks, so it doesn't seem to be a universal thing, but perhaps it doesn't work on initial opening of the PR, but does for subsequent pushes? Would have to test it out to see the boundaries. |
#26669 only touches files under matplotlib/.github/workflows/tests.yml Lines 15 to 18 in 389a7e8
|
2065f14 ran all the Github tests despite the commit message being However, I did not make the initial commit have this in the commit message. Is that the difference? |
Sorry, I meant #25175 broke this. the logic is indeed different: if |
"workflow_dispatch" is the keyword for "manually run action", i.e. running the action by clicking the "Run workflow" button in the GHActions web UI. I think if you are asking explicitly to run a workflow, it should run, regardless of whether the last commit has a I do wonder if "ignore paths" causes empty commits to skip, which made it look like it was working when I was testing it, though. |
Summary
When putting
[ci doc]
in the commit message, the GitHub tests all still run.matplotlib/.github/workflows/tests.yml
Line 39 in 389a7e8
ping @ksunden
Proposed fix
No response
The text was updated successfully, but these errors were encountered: