Skip to content

[Bug]: removing already extablished axis sharing #28345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rdg-netra opened this issue Jun 4, 2024 · 2 comments
Open

[Bug]: removing already extablished axis sharing #28345

rdg-netra opened this issue Jun 4, 2024 · 2 comments

Comments

@rdg-netra
Copy link

Bug summary

I have not been able to find a supported method for removing axis sharing that has already been established. At least, not without removing and re-creating the axis.

In older versions of matplotlib, it was possible to do:
ax1.get_shared_x_axes().remove(ax2)
but with the new axis grouper API, this is no longer possible ('GrouperView' object has no attribute 'remove').

There does seem to be a workaround using an internal variable:
ax1._shared_axes['x'].remove(ax2)

I would suggest that a natural way to support removing all axis sharing might be a method:

ax.set_shared_xaxis(None)

or possibly

ax.sharex(None)

Code for reproduction

import matplotlib.pyplot as plt

fig, (ax1, ax2) = plt.subplots(2, 1, sharex=True)
ax1.plot([0, 1, 2], [1, 2, 3])
ax2.plot([0, 1, 2], [3, 2, 1])

ax1.set_shared_xaxis(None)

plt.show()

Actual outcome

AttributeError: 'Axes' object has no attribute 'set_shared_xaxis'.

Expected outcome

Axis sharing should not be enabled.

Additional information

No response

Operating system

No response

Matplotlib Version

3.8.2

Matplotlib Backend

No response

Python version

3.10.13

Jupyter version

No response

Installation

conda
@anntzer
Copy link
Contributor

anntzer commented Jun 6, 2024

Unsharing was always problematic and not really actually supported; see e.g. the discussions at #1312 and #9923.

@rdg-netra
Copy link
Author

Thanks for that. I have looked through the discussion in the issues mentioned. I can see that it is indeed more tricky than it might at first seem.

My situation is that I have an interactive application with two figures where there are two possible modes of interaction with the data. I need to be able to toggle fairly quickly between modes. In one case, the x axis needs to be shared, the other not. It has been working for a long time with older matplotlib versions, so this issue means I either can't upgrade or need to use the internal variable workaround. Removing and re-creating the whole figure every time is really not something I want to do.

My reading of issue #15287 is that there was an intention to solve the easier problem, i.e. just allow clearing all sharing for an axis, rather than removing specific shares in a possibly complicated tree. In my case this would be fine since I don't have any complicated sharing structure. However, although the PR seemed to be accepted I couldn't really follow what happened here and if there is a supported way to do what I need.

If anyone has a better handle on situation or other suggestions that would be helpful.

If there really is no supported way to do it, I might suggest that the documentation for matplotlib.axes.Axes.sharex and Figure.subplots sharex argument should have a warning explaining not possible to remove sharing after those methods have been used.

@anntzer anntzer mentioned this issue Jun 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anntzer @rdg-netra