Skip to content

[ENH]: Expand hist() signature to support aliases and plural kwargs #28884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timhoffm opened this issue Sep 25, 2024 · 0 comments · Fixed by #29552
Closed

[ENH]: Expand hist() signature to support aliases and plural kwargs #28884

timhoffm opened this issue Sep 25, 2024 · 0 comments · Fixed by #29552
Milestone

Comments

@timhoffm
Copy link
Member

Problem

#28073 added support for arrays on edgecolor, facecolor, linewidth, linestyle, hatch.

#28873 noted that we do not support the arrays for the aliases ec, fc, ... We also do not support plural versions of these parameters edgecolors, facecolors, ...

This is a reasonable expectation.

Proposed solution

  • Alias support should be added.
  • I believe we should come up with a clearer general strategy on singular/plural versions of the kwargs. Some initial thoughts:
    • Make a survey of which functions already support array properties and via which APIs.
    • the singular versions exist as pass-through. They need to be supported anyway. We could (i) only accept singular values there or (ii) also accept sequences. (ii) seems the more user-friendly approach and is implemented in some APIs already.
    • if we support plurals, we need to internally merge the single and plural variants, same with aliases. We likely should make helper functions for this. Can aliases be reused?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants