-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Regression with cx_support in 1.4.0rc4 #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In style/core.py, the call to
|
This should be using pkg_resources. Preferably the "resource_stream" method On Tue, Aug 19, 2014 at 1:12 PM, Eric Firing notifications@github.com
|
More generally it would be great if you could add a unit test for On Tue, Aug 19, 2014 at 7:19 PM, Benjamin Root notifications@github.com
|
The bug certainly needs to be fixed ASAP, but doing it right might take some time. It will affect relatively few users. Therefore I don't think it should block 1.4.0, though if someone can come up with a good fix in time for 1.4.0, so much the better. |
Let's target this for a 1.4.1. We can't keep holding off 1.4.0. I do have On Tue, Aug 19, 2014 at 3:24 PM, Eric Firing notifications@github.com
|
Breaking cx_Freeze support is a pretty big deal IMHO. Again, I reiterate On Wed, Aug 20, 2014 at 3:31 AM, Benjamin Root notifications@github.com
|
You are more than welcome to read up on pkg_resources and submit a patch I also have nothing against adding some sort of automated build test for On Wed, Aug 20, 2014 at 3:16 AM, Ian Bell notifications@github.com wrote:
|
I think I could help with setting up a test for cx_Freeze since I have Go ahead with 1.4.0, I can put a warning for my users to use 1.3.1 for now. On Wed, Aug 20, 2014 at 3:27 PM, Benjamin Root notifications@github.com
|
Py2exe is also broken. Wouldn't the |
Moving the diff --git a/lib/matplotlib/style/core.py b/lib/matplotlib/style/core.py
index 02efe1f..8bd0d13 100644
--- a/lib/matplotlib/style/core.py
+++ b/lib/matplotlib/style/core.py
@@ -27,8 +27,7 @@ from matplotlib import rc_params_from_file
__all__ = ['use', 'context', 'available', 'library', 'reload_library']
-_here = os.path.abspath(os.path.dirname(__file__))
-BASE_LIBRARY_PATH = os.path.join(_here, 'stylelib')
+BASE_LIBRARY_PATH = os.path.join(mpl.get_data_path(), 'stylelib')
# Users may want multiple library paths, so store a list of paths.
USER_LIBRARY_PATHS = [os.path.join(mpl._get_configdir(), 'stylelib')]
STYLE_EXTENSION = 'mplstyle' |
I like that solution and we can get it in for 1.4.0, could you put it in a pr? I will do it if a get to a real computer before you do. I don't think moving a data file requires a new tv |
Awesome! Thanks very much guys - I look forward to using 1.4.0/ On Thu, Aug 21, 2014 at 3:58 AM, Eric Firing notifications@github.com
|
I tried to package an app dependent on mpl using 1.3.1 - no problems.
When I upgrade to 1.4.0rc4, I get the following traceback when I try to start my app. Not so nice. Looks like it is looking for an absolute path for styles within the zip file which is a no-no obviously.
The text was updated successfully, but these errors were encountered: