Skip to content

Pytz should be specified and documented as a required dependency #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cgohlke opened this issue Aug 27, 2014 · 4 comments
Closed

Pytz should be specified and documented as a required dependency #3423

cgohlke opened this issue Aug 27, 2014 · 4 comments
Milestone
v1.4.1

Comments

@cgohlke
Copy link
Contributor

cgohlke commented Aug 27, 2014

The pytz package is not specified in setupext.py or documented in INSTALL as a required dependency even though it is still used in axis.py and dates.py. Pytz was previously bundled with matplotlib.
@tacaswell tacaswell added this to the v1.4.0 milestone Aug 27, 2014
@tacaswell tacaswell added the doc label Aug 27, 2014
@tacaswell
Copy link
Member

iirc, this is a dependency of a dependency

@cgohlke
Copy link
Contributor Author

cgohlke commented Aug 27, 2014

There are direct imports of pytz in axis.py and dates.py.

@tacaswell
Copy link
Member

Never mind, I was confused. For a while we didn't list six as a dependency because it was installed by one of the other dependencies, but it looks like that is not the case here.

My current plan is to put it in the 'optional' section as it is only needed if you specify the time zone.

@mdboom Thoughts on this?

@tacaswell tacaswell mentioned this issue Aug 28, 2014
Merged
@tacaswell tacaswell modified the milestones: v1.4.0, v1.4.x Aug 28, 2014
@tacaswell
Copy link
Member

punted to 1.4.x as there is a doc only PR in for 1.4.0.

@tacaswell tacaswell added needs_patch and removed doc labels Aug 28, 2014
@tacaswell tacaswell modified the milestones: v1.4.x, v1.4.1 Sep 3, 2014
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Sep 6, 2014
@tacaswell
BLD/BUG/DOC : made pytz a required dependency
99c04e9 
closes matplotlib#3423
@tacaswell tacaswell mentioned this issue Sep 6, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

No branches or pull requests
2 participants
@tacaswell @cgohlke