-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Matplotlib Installing Test Dependencies #3649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The more common pattern is to make nose, mock "extra" dependencies in the setuptools sense (as in |
"extra" dependencies seem to be deprecated. I would suggest that we use tests_require to specify the test dependencies and then register a TestCommand in the setup.py. This means that upon running
|
@HolgerPeters My understanding of the history of our setup.py and test suite is that they pre-dated many of today's standard best practices/tools and grew organically over time. This has resulted in something that works, but is a bit Frankenstein like, even by the standards of python + c-extension packaging. If you would like to take a crack at cleaning up/modernizing/making sane the build scripts please go for it! On the radar is also to make sure we have a working conda recipe in our repo. |
Yes they are no longer installed automatically |
Hi,
it seems that matplotlib by default now pulls dependencies for testing, such as
nose
andmock
. While this might be handy for a matplotlib developer, I think this should not be the default for a matplotlib user.I think the more canonical behaviour would be to install matplotlib (with its tests even) and then let the user install nose and test if they want to run the tests.
I would be willing to contribute a pull request removing the nose and mock from the list of install requirements.
The text was updated successfully, but these errors were encountered: