-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Pull in JSAnimation #4703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Longer term, it would be nice to refactor animation code so that the |
As one user, this would make me happy... |
JSAnimation no longer works with matplotlib 1.5 -- jakevdp suggested that the new display hooks in 8cc21db may be the culprit. It's a handy tool for notebooks, especially as the animations remain functional when rendered by nbviewer. |
I've got a PR that's waiting to pull JSAnimation into matplotlib #4821. |
Ahh. apologies! That's great news. |
@gforsyth – I couldn't reproduce the issues that were reported on twitter: seems to work on 1.5 for me. Does anyone have an example that breaks? |
@jakevdp - The animation in this notebook isn't working for me on two separate machines (one running jupyterhub, the other local). https://github.com/numerical-mooc/numerical-mooc/blob/master/lessons/03_wave/03_02_convectionSchemes.ipynb Everything loads (no errors thrown), but the buttons are unresponsive and no animation plays |
Found the source of the problem: with matplotlib 1.5, the HTMLWriter only outputs a single frame. I'm still not sure what caused this change however... |
It would be easier to debug with a minimal non-notebook example that fails. I have to pivot to something else now — I would be much more likely to be able to debug this soon if someone were to tackle creating a minimal complete example that reproduces the bug. |
@jenshnielsen @jakevdp Thanks! That fixed it on my end -- JSAnimation working as expected. Thanks for your help! |
Pulling in https://github.com/jakevdp/JSAnimation (which hasn't changed in over a year) would greatly enhance the experience of using animations in the notebook with stock matplotlib. Also, like trendvis, oceancm, and viscm, this would move an very useful matplotlib-based tool into our fold.
The core implementation of JSAnimation is just two parts:
The
HTMLWriter
clearly makes sense in matplotlib (alongsideFFMpegWriter
, etc.). I'm not sure what to do with the IPython display code. Adding it as a_repr_html
might not be too bad.Thoughts?
The text was updated successfully, but these errors were encountered: