Skip to content

numpy incompatibility #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tacaswell opened this issue Sep 15, 2015 · 10 comments
Closed

numpy incompatibility #5078

tacaswell opened this issue Sep 15, 2015 · 10 comments
Assignees
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone

Comments

@tacaswell
Copy link
Member

We have non np 1.6 compatible code in the gdk backend which we do not test on travis.

Issue reported by @cgohlke

http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-First-release-candidate-for-the-1-5-0-series-tp46156p46166.html

http://stackoverflow.com/questions/28499580/matplotlib-import-error-backend-gdk-soundefined-symbol-pyarray-setbaseobjec

The code in question went in in
#3665

which was in response to discussion at

http://thread.gmane.org/gmane.comp.python.matplotlib.general/34771/focus=34771

Options here are:

  • fix code to address both issues (no idea how hard that would be)
  • up the minimal numpy until it works

I am in favor of bumping the numpy version, but do not feel strongly.

@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 15, 2015
@tacaswell tacaswell added this to the next point release milestone Sep 15, 2015
@tacaswell
Copy link
Member Author

@mdboom
Copy link
Member

mdboom commented Sep 15, 2015

I don't have any objections to dropping numpy 1.6 support.

We should probably add the magic incantation that enforces the Numpy 1.7 API if we do this so it doesn't regress again, but I don't know how many changes would be required... That can wait for another PR, of course.

@jkseppan
Copy link
Member

If the fix is as simple as https://github.com/scipy/scipy/blob/master/scipy/signal/lfilter.c.src#L285-L292 I think we should just apply it. Is there a simple test case? I don't regularly use the gdk backend.

@jkseppan
Copy link
Member

Oh, I guess it would be a compile-time error so the test case is easy if I can otherwise get gdk to compile?

@mdboom
Copy link
Member

mdboom commented Sep 15, 2015

Yeah -- I think if we can install the gtk development packages on Travis, this extension would get built and then we'd at least catch simple compilation errors.

@jkseppan
Copy link
Member

I think the fix would be something like jkseppan@4ab9919 but I didn't even try to compile it yet.

@jkseppan
Copy link
Member

Unfortunately it's not a compilation error: it's just

    src/_backend_gdk.c:55:5: warning: implicit declaration of function ‘PyArray_SetBaseObject’ [-Wimplicit-function-declaration]
         PyArray_SetBaseObject(array, (PyObject *)py_pixbuf);
         ^

But import matplotlib.backends.backend_gdk triggers the error for me.

@jkseppan
Copy link
Member

Would appreciate review of #5080, especially by someone who uses backend_gdk actively.

@OceanWolf
Copy link
Member

Probably easier to do a shout-out on the mailing list for this? Not so many people get alerted to issues/PRs...

@jkseppan
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

No branches or pull requests

4 participants