-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
numpy incompatibility #5078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We would only have to bump to 1.7 http://docs.scipy.org/doc/numpy-dev/reference/c-api.array.html#c.PyArray_SetBaseObject |
I don't have any objections to dropping numpy 1.6 support. We should probably add the magic incantation that enforces the Numpy 1.7 API if we do this so it doesn't regress again, but I don't know how many changes would be required... That can wait for another PR, of course. |
If the fix is as simple as https://github.com/scipy/scipy/blob/master/scipy/signal/lfilter.c.src#L285-L292 I think we should just apply it. Is there a simple test case? I don't regularly use the gdk backend. |
Oh, I guess it would be a compile-time error so the test case is easy if I can otherwise get gdk to compile? |
Yeah -- I think if we can install the gtk development packages on Travis, this extension would get built and then we'd at least catch simple compilation errors. |
I think the fix would be something like jkseppan@4ab9919 but I didn't even try to compile it yet. |
Unfortunately it's not a compilation error: it's just
But |
Would appreciate review of #5080, especially by someone who uses backend_gdk actively. |
Probably easier to do a shout-out on the mailing list for this? Not so many people get alerted to issues/PRs... |
I mentioned it at http://permalink.gmane.org/gmane.comp.python.matplotlib.devel/13729 |
We have non np 1.6 compatible code in the gdk backend which we do not test on travis.
Issue reported by @cgohlke
http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-First-release-candidate-for-the-1-5-0-series-tp46156p46166.html
http://stackoverflow.com/questions/28499580/matplotlib-import-error-backend-gdk-soundefined-symbol-pyarray-setbaseobjec
The code in question went in in
#3665
which was in response to discussion at
http://thread.gmane.org/gmane.comp.python.matplotlib.general/34771/focus=34771
Options here are:
I am in favor of bumping the numpy version, but do not feel strongly.
The text was updated successfully, but these errors were encountered: