-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Default setting of figure transparency in NbAgg is a performance problem #5419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the reason why that setting was set that way was to match the On Fri, Nov 6, 2015 at 9:53 AM, Michael Droettboom <notifications@github.com
|
Ok -- that at least makes some sense. But wouldn't setting the background to white for inline images also be one way to fix that?
Meaning you hate that the inline images are transparent or vice versa? |
Correct, setting the background to white for inline images would fix that, On Fri, Nov 6, 2015 at 10:33 AM, Michael Droettboom <
|
Yes -- I think IPython sets the transparent background on inline images. We can always lobby them to stop if that makes sense... ;) |
This sounds related to a problem I just ran into with master, and with |
We could be more sophisticated with the solution - we could send over only the semi-transparent pixels as a separate message and clear those pixels before applying them on the JS side. Either way, I'm 👍 on producing white borders by default - for both nbagg and all other backends. I've disliked the fact that we have a |
I missed the implications of #3552 when it went through.
If any part of the plot image is transparent, a full image frame is sent in order to make sure there isn't any ghosting. The default value of
nbagg.transparent == True
unfortunately means that full images are always sent for every frame. This results in lower framerates and flickering.I can workaround this by setting
figure.facecolor: white
andnbagg.transparent: False
, but I wonder if we shouldn't make this the default. 2.0 might be a good opportunity to makefigure.facecolor: white
the default for every backend anyway, which does generally look more modern.It does mean it IPython ever changes their style to something on a non-white background things may not look as nice, but we'll cross that when we get there.
Cc: @pelson
The text was updated successfully, but these errors were encountered: