Skip to content

QuadMesh.draw(): convert_xunits broken #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfroehle opened this issue Oct 27, 2011 · 3 comments
Closed

QuadMesh.draw(): convert_xunits broken #560

bfroehle opened this issue Oct 27, 2011 · 3 comments

Comments

@bfroehle
Copy link
Contributor

In QuadMesh.draw(), I think the following code is broken

xs = self.convert_xunits(self._offsets[:0]) ys = self.convert_yunits(self._offsets[:1])

because it is missing a comma between the : and 0 (or : and 1).

@pelson
Copy link
Member

pelson commented Aug 19, 2012

Thanks @bfroehle: can you provide an example where this is manifest?

@efiring
Copy link
Member

efiring commented Jul 22, 2013

This is a blatant bug; the code as it still exists makes no sense whatsoever. The only question is whether to just put in the commas, or whether the whole block of code involving offsets can be deleted. Are offsets supported in QuadMesh?

efiring added a commit to efiring/matplotlib that referenced this issue Jul 22, 2013
@efiring
Copy link
Member

efiring commented Jul 22, 2013

Answering my own question, yes, it looks like offsets are supported, so I added the commas.
Evidently no one has been trying to use offsets with units in pcolormesh...and maybe no one ever will.

@mdboom mdboom closed this as completed Jul 22, 2013
mdboom added a commit that referenced this issue Jul 22, 2013
bug: fix unit support for offsets in QuadMesh; closes #560
mdboom added a commit that referenced this issue Jul 22, 2013
bug: fix unit support for offsets in QuadMesh; closes #560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants