Skip to content
  • Sponsor matplotlib/matplotlib

  • Notifications You must be signed in to change notification settings
  • Fork 7.9k

QuadMesh.draw(): convert_xunits broken #560

Closed
@bfroehle

Description

@bfroehle

In QuadMesh.draw(), I think the following code is broken

xs = self.convert_xunits(self._offsets[:0]) ys = self.convert_yunits(self._offsets[:1])

because it is missing a comma between the : and 0 (or : and 1).

Activity

pelson

pelson commented on Aug 19, 2012

@pelson
Member

Thanks @bfroehle: can you provide an example where this is manifest?

efiring

efiring commented on Jul 22, 2013

@efiring
Member

This is a blatant bug; the code as it still exists makes no sense whatsoever. The only question is whether to just put in the commas, or whether the whole block of code involving offsets can be deleted. Are offsets supported in QuadMesh?

added a commit that references this issue on Jul 22, 2013
071158b
efiring

efiring commented on Jul 22, 2013

@efiring
Member

Answering my own question, yes, it looks like offsets are supported, so I added the commas.
Evidently no one has been trying to use offsets with units in pcolormesh...and maybe no one ever will.

added 2 commits that reference this issue on Jul 22, 2013

Merge pull request #2238 from efiring/quad_offset_bug

54f7d3e

Merge pull request #2238 from efiring/quad_offset_bug

6846892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      QuadMesh.draw(): convert_xunits broken · Issue #560 · matplotlib/matplotlib