Barbs broken #5803
Assignees
Milestone
Comments
|
I have the same suspicion. |
|
Unfortunately, in this case, barbs require both filled and unfilled parts, so diff --git a/lib/matplotlib/quiver.py b/lib/matplotlib/quiver.py
index aef58c9..d7b9012 100644
--- a/lib/matplotlib/quiver.py
+++ b/lib/matplotlib/quiver.py
@@ -922,6 +922,9 @@ class Barbs(mcollections.PolyCollection):
kw['edgecolors'] = barbcolor
kw['facecolors'] = flagcolor
+ if 'linewidth' not in kw:
+ kw['linewidth'] = 1
+
# Parse out the data arrays from the various configurations supported
x, y, u, v, c = _parse_args(*args)
self.x = x |
|
This is someplace where that kwarg normalization function I have in #5056 would be nice to use here to make sure we don't clobber 'lw'. |
tacaswell
added a commit
that referenced
this issue
Jan 26, 2016
Make barbs draw correctly (Fixes #5803)
tacaswell
added a commit
that referenced
this issue
Jan 26, 2016
Make barbs draw correctly (Fixes #5803) Conflicts: lib/matplotlib/tests/test_quiver.py white space vs new test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I guess there were some line (or polygon edge?) changes with the new style. It turns out this broke
Barbs. Here are the results running thebarb_demo.pyexample.Good (1.5.x):
Bad (master):
It turns out that there are 0 tests for the
Barbscode. I'm willing to submit a PR to fix the problem and add some tests (probably just knock off the demo). Since I think I've seen mention of similar issues elsewhere, can someone point me to what exactly needs to be added, maybe some kind of edge/line style or color?The text was updated successfully, but these errors were encountered: