-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
scatter + loglog = bad autolimits #5897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is indeed something fishy going on in the log scale autolimit logic. I have found a similar problem when using a
|
This resulted in a hour long phone discussion. It seems there are significant order of operations issues here. |
OK, I got it: this is because the data limits of a collection include the physical extent of the artists that are part of the collection (in this case, the markers). I guess this is necessary because artists may be quite large... |
Yes, it looks like a different issue. @tacaswell: when you mention there is an order of operations issue did you mean with @anntzer's issue or the autolimit/zoom issue I mentioned? Maybe I should split it into a new issue... |
@zblz: I am not sure that there is much to do about the issue you are raising. I guess the only alternative would be to store (upon a call to |
@anntzer: In my opinion, the current behaviour is more confusing: if a limit is set automatically to 20% beyond the data range, I expect this to hold always, even when I change the range. So I would be in favor of storing which limits are automatic and which have been manually set, and compute the auto limits on every new view given the manually set ones. |
Fair enough. Coming back to my own issue: I thought that at least in theory, collections could return their limits as "data-value limit + axes-value limit" (the latter coming from the e.g. rightmost artist). However things are more complicated, because which artist has its rightmost point the furthest can depend on the xlims themselves (a larger artist more to the left can "catch up" a smaller artist more to the right if the scaling is compressed enough). |
I think this was closed by #7410 |
My example still suffers from the issue described in #7413. |
|
Fixed by #13642, I believe. |
master


1.5.1
I've also had cases where the bottom of the line plot was cut out, although I don't have a minimal example yet.
The text was updated successfully, but these errors were encountered: