Skip to content

document and test Arrow and FancyArrow #7213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dopplershift opened this issue Oct 3, 2016 · 5 comments
Closed

document and test Arrow and FancyArrow #7213

dopplershift opened this issue Oct 3, 2016 · 5 comments
Labels
Documentation status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. status: inactive Marked by the “Stale” Github Action topic: arrow

Comments

@dopplershift
Copy link
Contributor

See #6583.

The code is pretty crufty, there are no tests, and it's not clear at all what the units are for drawing these things.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Oct 3, 2016
@dstansby
Copy link
Member

dstansby commented Mar 6, 2017

Yes please. I was just about to open a bunch of issues for ax.arrow()...

@dstansby
Copy link
Member

Having another look into the whole arrow business(/mess), and it looks like Arrow and FancyArrow are arrows where all the vertices are rigidly fixed in data space, which I think is something useful to have.

@efiring
Copy link
Member

efiring commented Jun 18, 2017

Why is that useful? It makes them behave badly when anything changes the aspect ratio.

@dstansby
Copy link
Member

In response to the the original report, I'm happy to add tests, and I think it's now clear what the units are for drawing the arrows (#8770). They might not be the best way to draw an arrow in 99% of use cases, but as long as they're well documented (which I'm happy to do) I don't really see a need to get rid of them.

@tacaswell tacaswell modified the milestones: 2.2 (next next feature release), 2.1 (next point release) Jul 11, 2017
@tacaswell tacaswell changed the title Deprecate Arrow and FancyArrow document and test Arrow and FancyArrow Jul 11, 2017
@dstansby dstansby removed their assignment May 12, 2019
@github-actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Mar 31, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
@rcomer rcomer added the status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. status: inactive Marked by the “Stale” Github Action topic: arrow
Projects
None yet
Development

No branches or pull requests

6 participants