-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove numpy 1.6 specific work-arounds #7484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The first 4 of those should be fixed in my pull request. The last two I'm not entirely sure what the comments mean/what needs changing... |
is just that numpy1.6 doesn't support unicode and it's a unicode test. That comment can be removed now. And while editing that file, TestConvertToString should also be removed. |
colors is weird 'cause that try catch is just to test if what's passed in is a floating point. I think the idea is that the c is expected to have been a numpy float array, and that's why it's being cast to a builtin float (as in 170). You may be able to remove that statement 'cause in theory other types were already captured, (and also remove the cast in 170)... though you may possibly need to put in a c = np.asarray(c, dtype=float) before 170 (possibly in a try/catch). |
Basically something breaks later (on Py2.7+numpy1.6) if a tuple of numpy floats (rather than builtin floats) is returned. See 2fe2c26. In fact I don't think that the version that starts with As a side note, either implementation suffers from the fact that the cast to float doesn't error when a string is passed in (as in |
In #7396 / #7483 we bumped the minimum numpy version to 1.7.1. We have a number of workarounds in the code base which should be removed
From master:
I would prefer is we not backport these for 2.0 (just being excessively conservative).
attn @story645
The text was updated successfully, but these errors were encountered: