Skip to content

Deprecate assert_str_equal #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dstansby opened this issue Feb 20, 2017 · 3 comments
Closed

Deprecate assert_str_equal #8112

dstansby opened this issue Feb 20, 2017 · 3 comments
Labels
topic: testing
Milestone
v2.1

Comments

@dstansby
Copy link
Member

Judging by codecov, assert_str_equal in tests/__init__.py is never used (https://codecov.io/gh/matplotlib/matplotlib/src/master/lib/matplotlib/tests/__init__.py#L22), and grep agrees:

$ grep -r 'assert_str_equal' lib/
lib//matplotlib/tests/__init__.py:def assert_str_equal(reference_str, test_str,

So I don't see why it shouldn't be deprecated and then removed.
@tacaswell
Copy link
Member

I think there may be a PR in flight to do that, possibly from @dopplershift ?

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Feb 20, 2017
@anntzer
Copy link
Contributor

anntzer commented Feb 21, 2017

I doubt so given that assert_str_equal was still in use until very recently (removed by @QuLogic in #8026).

@anntzer anntzer mentioned this issue Feb 21, 2017
Merged
@QuLogic
Copy link
Member

QuLogic commented Feb 23, 2017

Fixed by #8118.

@QuLogic QuLogic closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@tacaswell @QuLogic @anntzer @dstansby