-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
make.py should not use os.system("sphinx-build ...")
#8208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looking at the contents of
|
I don't understand your concern; why would it pick up There is a problem on Python 3 though if using system packages, because they generally install both |
It's quite common in my experience for me to have |
Oh yes, not having it installed at all, good point. We can fix this now, but I think there's not really much of a way to fix this when switching to the Makefile, though. |
Actually, as of sphinx 1.5.3, you can just do
Perhaps we can just check since when this form is supported and update the requirement. I will open an issue upstream to fix their Makefile/make.bat as well. |
Closed by #8269. |
I know the plan is to switch to a doc makefile, but the issue would be the same.
Calling
os.system("sphinx-build ...")
(or directlysphinx-build
in the Makefile) will pick up a sphinx install outside of the current environment, which may or may not have an unrelated (e.g., older) version of matplotlib installed. Instead, the command should be something likepython -msphinx build ...
if sphinx offers that option, or we should use a wrapper script otherwise that makes sure that sphinx is used from the current environment only.The text was updated successfully, but these errors were encountered: