Skip to content

seaborn styles make "+", "x" markers invisible; proposed workaround for shipped styles #8351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anntzer opened this issue Mar 20, 2017 · 4 comments
Milestone

Comments

@anntzer
Copy link
Contributor

anntzer commented Mar 20, 2017

It is a somewhat well-known issue (#4679) that seaborn's styles make "+", "x" markers invisible by default (because they set lines.markeredgewidth to zero). Although it may be helpful to use a separate rcparam to control such markers, this is not trivial (see linked issue). Instead, in this issue, I'd like to argue that matplotlib should not ship styles available by default where some markers are completely invisible; instead, we may e.g. set lines.markeredgewidth to a tiny value, so that the markers are at least faintly visible (and it may be easier to realize where the issue comes from), even though it is not strictly equivalent to the "official" seaborn style.

From simple attempts, it seems that a value like 0.25 should be enough.

@mwaskom
Copy link

mwaskom commented May 31, 2017

I think this can be handled once #8479 lands by setting markeredgecolor to "auto", as per de7bc93, and then setting marker edge widths to any reasonable nonzero value.

@dmcooke
Copy link

dmcooke commented Jan 21, 2022

Just hit this bug. Took me a while to figure out why my '+' marker wasn't showing (I'm using the seaborn-notebook style).

@mwaskom
Copy link

mwaskom commented Jan 21, 2022

This is looong since fixed in seaborn itself, but unfortunately matplotlib refuses to fix the style sheets they ship: #13680

@anntzer
Copy link
Contributor Author

anntzer commented Jan 29, 2022

I think this is effectively closed by #22317 (the old styles will stay what they are given the backcompat concerns, but they point to seaborn itself).

@anntzer anntzer closed this as completed Jan 29, 2022
@anntzer anntzer added this to the v3.6.0 milestone Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants