-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
restore rebase documenation #8398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Never mind, I apparently can not read 🐑 http://matplotlib.org/devel/gitwash/development_workflow.html Sorry for the noise. |
#2742 <- most of this content is gone |
Looks like this is a result of #8137 |
Just a quick thought on this text - it might be worth highlighting the interactive rebase earlier on. This is probably going to be more useful for committers who are asked to squash before merge. Right now it's in a section after the first mention of rebase: It isn't the easiest to discover. Maybe the rebase section just needs a "see for more ways to rebase", or maybe just adding in the words "squash before merge" etc so that people can ctrl+f it more easily. WDYT? |
Which text is 'this text'? Compare what we publish now with https://github.com/tacaswell/matplotlib/blob/9efe5e36b57bf11fb2bfd7e9229c06656fd10bff/doc/devel/gitwash/development_workflow.rst |
I'm just saying that if I were a new user opening a PR, looking for an explanation of how to squash a bunch of commits before merging, then this: is what I should use, but it'd be hard for me to find it. I think if the words "squash and merge" or something like this were in there, it'd be easier to find,
in this section: it'd be easier to find |
matthew-brett/gitwash#13 ports the missing text to upstream gitwash. |
Is this closed since we have rebase documentation now? https://matplotlib.org/devdocs/devel/development_workflow.html#rebasing-on-upstream-main |
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help! |
Done per #8398 (comment). |
This content is no longer on the master branch, not sure if it is also gone from 2.0.x
http://matplotlib.org/devel/gitwash/development_workflow.html?highlight=rebase#rebasing-a-pull-request-pr
This needs to be put back.
The text was updated successfully, but these errors were encountered: