Remove some deprecated rcParams. #10028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
981d8cd to
12a2224
Compare
dstansby
reviewed
Dec 18, 2017
lib/matplotlib/tests/test_style.py
Outdated
| SETTINGS = {'axes.color_cycle': 'ffffff'} | ||
| basename = 'color_cycle' | ||
| SETTINGS = {'foo': 'bar'} | ||
| basename = 'basename' |
There was a problem hiding this comment.
Renamed as "test_invalid_rc_warning_includes_filename", which seems still a valid test.
- axes.color_cycle was deprecated in 1.5 (68f0afb). - legend.isaxes was deprecated in 2.0 (64accfd). - svg.embed_char_paths was deprecated in 1.3.1 (6d660ce). - svg.image_noscale was deprecated in 2.1 (4a05302) but note that the deprecation was broken to start with as it used None as converter (so trying to set `rcParams["svg.image_noscale"]` currently raises `'NoneType' object is not callable`. - text.* and tick.size were deprecated before 1.3.1 (e34a333).
12a2224 to
18b5c87
Compare
dstansby
approved these changes
Dec 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecation was broken to start with as it used None as converter (so
trying to set
rcParams["svg.image_noscale"]currently raises'NoneType' object is not callable).PR Summary
PR Checklist