Skip to content

Backport PR #10030 on branch v2.1.x #10058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lumberbot-app[bot]
Copy link

@lumberbot-app lumberbot-app bot commented Dec 20, 2017

Backport PR #10030: Fix using .get_color() and friends in labels handling

@lumberbot-app lumberbot-app bot added this to the v2.1.2 milestone Dec 20, 2017
@jklymak
Copy link
Member

jklymak commented Dec 21, 2017

A little help here. #10030 was merged because #10031 depended on it and they were both milestones 2.1.2 so they got meeseek-ed. If we merge (EDIT:) #10057 will this one get merged? Or do we have to merge this one first?

@QuLogic
Copy link
Member

QuLogic commented Dec 21, 2017

#10059 is closed?

@jklymak
Copy link
Member

jklymak commented Dec 21, 2017

Oops, sorry, the PR numbers went backwards:

#10030 -> #10058
#10031 -> #10057

@QuLogic
Copy link
Member

QuLogic commented Dec 21, 2017

OK, I'm a little surprised meeseeksdev was able to backport both of them; I think there's no need for this one as the #10031 backport is squashed and would then conflict with this one.

@QuLogic QuLogic closed this Dec 21, 2017
@QuLogic QuLogic deleted the auto-backport-of-pr-10030 branch December 21, 2017 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants