Skip to content

Improve lazy-ticks realization. #10690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2018
Merged

Improve lazy-ticks realization. #10690

merged 1 commit into from
Mar 7, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 5, 2018

PR Summary

Fixes #10654 (comment).

("realization" as in "making the tick list real"...)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v2.2.1 milestone Mar 5, 2018
timhoffm
timhoffm approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved conditionally on CI passing.

@efiring efiring mentioned this pull request Mar 6, 2018
Merged
3 tasks
@jklymak jklymak merged commit 97f360a into matplotlib:master Mar 7, 2018
lumberbot-app bot pushed a commit that referenced this pull request Mar 7, 2018
@jklymak
Backport PR #10690: Improve lazy-ticks realization.
5892107
@lumberbot-app lumberbot-app bot mentioned this pull request Mar 7, 2018
Merged
jklymak added a commit that referenced this pull request Mar 7, 2018
@jklymak
Merge pull request #10706 from matplotlib/auto-backport-of-pr-10690
9d7375f 
Backport PR #10690 on branch v2.2.x
@anntzer anntzer deleted the lazyticks branch March 7, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.

PySmithPlot/Polar Plot update broken in 2.1.2 (works in 2.0.2)
3 participants
@anntzer @jklymak @timhoffm