Skip to content

Backport PR #11090 on branch v2.2.2-doc #11102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lumberbot-app[bot]
Copy link

@lumberbot-app lumberbot-app bot commented Apr 22, 2018

Backport PR #11090: Clean docstring of CountourSet

@lumberbot-app lumberbot-app bot added this to the v2.2-doc milestone Apr 22, 2018
@jklymak
Copy link
Member

jklymak commented Apr 22, 2018

Ughhh this is failing on pie. Did we accidentally back port the pie changes to the doc branch?

@QuLogic
Copy link
Member

QuLogic commented Apr 24, 2018

Changes to .py files should not be backported to the -doc branch anyway.

@jklymak
Copy link
Member

jklymak commented Apr 24, 2018

Not even documentation changes? We've been back porting a lot of those.

@QuLogic
Copy link
Member

QuLogic commented Apr 24, 2018

They should not have been (in the sense that it's unnecessary, not that it breaks things.) They have no effect due to the way the docs are built. At most, they should go to v2.2.x. See #10822.

@jklymak
Copy link
Member

jklymak commented Apr 24, 2018

OK, then closing!

@jklymak jklymak closed this Apr 24, 2018
@QuLogic QuLogic deleted the auto-backport-of-pr-11090 branch April 24, 2018 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants