Skip to content

Use super() instead of manually fetching supermethods for parasite axes. #11678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2018
Merged

Use super() instead of manually fetching supermethods for parasite axes. #11678

merged 2 commits into from
Jul 17, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 17, 2018

PR Summary

This manual fetching was previously done in _get_base_axes_attr.

Second commit style-cleans the module.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.1 milestone Jul 17, 2018
timhoffm
timhoffm approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, apart from the "do not use" comment that should be clarified.

lib/mpl_toolkits/axes_grid1/parasite_axes.py
@@ -224,13 +199,9 @@ def get_aux_axes(self, tr, viewlim_mode="equal", axes_class=None):
return ax2

def _get_legend_handles(self, legend_handler_map=None):
# don't use this!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jklymak You put this coment in last year. Why? Should it be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9324 (comment) I think the whole method should be removed, but maybe I'll put that in as a separate PR and not burden @anntzer with sorting out this stuff as part of an otherwise straightforward PR

@jklymak jklymak merged commit 8b46f31 into matplotlib:master Jul 17, 2018
@anntzer anntzer deleted the parasite-super branch July 17, 2018 20:37
@tacaswell tacaswell modified the milestones: v3.1, v3.0 Jul 17, 2018
@anntzer anntzer mentioned this pull request Jul 17, 2018
Merged
6 tasks
@kmuehlbauer kmuehlbauer mentioned this pull request Sep 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @tacaswell