Skip to content

Revert "Skip wx interactive tests on OSX." #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

Reverts #11593

Lets see if wx is fixed!

@tacaswell tacaswell modified the milestones: v3.0, v3.1 Jul 19, 2018
@tacaswell
Copy link
Member Author

It now timesout rather than segfaulting which is a step in the right direction!

@DietmarSchwertberger Do you have any suggestions on this one?

@DietmarSchwertberger
Copy link
Contributor

@tacaswell : Please give me a few days to test this on OS X.
Also, it's not clear to me which versions of Python and wxPython and are failing.

@DietmarSchwertberger
Copy link
Contributor

I have just tried in a VM with Python 3.6 and wxPython 4.0.3. For me it seems to work.
As expected, I can trigger a timeout by commenting out the fig.canvas.mpl_connect.....
Maybe the segfaults were related to the old timer implementation where the timer sent events to the frame and the frame got destroyed.

@tacaswell tacaswell closed this Feb 23, 2019
@tacaswell tacaswell deleted the revert-11593-skiposxwx branch February 23, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants