-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Make default arrow head width sensible #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What do these magic numbers mean? Why is 20 of them better than 3 of them? (other than experimental evidence) This change will need an entry in the api changelog. |
Yes, so it's unclear. The |
Would we prefer an |
I'm not sure about this now. The scale factor is only used when a user hasn't specified an arrow width - if the user were looking to change this they should set the width directly rather than setting a scale factor indirectly in Personally I'd be happy to merge this if you wouldn't mind re-basing? |
Currently the default head width is too small to produce a visible arrow head by default, so make it bigger.
Done. |
👍. Anybody else want to comment? If not, I'll merge in the next 48 hrs. Cheers @dmcdougall |
@pelson Want to go ahead with this? |
Make default arrowhead width more sensible
Currently the default head width is too small to produce a visible arrow head by default, this explains the behaviour described in #1096. It is not the case that there is not enough information in the documentation to plot an arrow.