Skip to content

Make default arrow head width sensible #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2013
Merged

Conversation

dmcdougall
Copy link
Member

Currently the default head width is too small to produce a visible arrow head by default, this explains the behaviour described in #1096. It is not the case that there is not enough information in the documentation to plot an arrow.

@travisbot
Copy link

This pull request fails (merged d636190 into cf7618c).

@pelson
Copy link
Member

pelson commented Sep 2, 2012

What do these magic numbers mean? Why is 20 of them better than 3 of them? (other than experimental evidence)
Perhaps these magic numbers could be dropped into the rcParams?

This change will need an entry in the api changelog.

@dmcdougall
Copy link
Member Author

Yes, so it's unclear. The FancyArrow docstring is also not clear about what they are. The kwarg width is the width of the arrow tail. Its default value is 0.001, but the docstring does not say what the units are. My first reaction was to say they in points, but I think thats too small. The kwarg head_width controls the width of the arrow head, its default is set to three times that of width. This would mean the units are the same but, again, I don't know what they are.

@dmcdougall
Copy link
Member Author

Would we prefer an rcParam for this instead? I'm starting to think that would be a better approach...

@pelson
Copy link
Member

pelson commented Mar 30, 2013

Would we prefer an rcParam for this instead?

I'm not sure about this now. The scale factor is only used when a user hasn't specified an arrow width - if the user were looking to change this they should set the width directly rather than setting a scale factor indirectly in rcParams.

Personally I'd be happy to merge this if you wouldn't mind re-basing?

Currently the default head width is too small to produce a visible arrow
head by default, so make it bigger.
@dmcdougall
Copy link
Member Author

Done.

@pelson
Copy link
Member

pelson commented Mar 30, 2013

👍. Anybody else want to comment? If not, I'll merge in the next 48 hrs.

Cheers @dmcdougall

@dmcdougall
Copy link
Member Author

@pelson Want to go ahead with this?

pelson added a commit that referenced this pull request Apr 2, 2013
Make default arrowhead width more sensible
@pelson pelson merged commit 6be9771 into matplotlib:master Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants