Fix Bezier degree elevation formula in backend_cairo. #12795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quad_bezier example would previously fail under the cairo backend; this patch fixes it.
|
Can you please add a testcase, or at least post some example code so that I can check that the patch is working without having to dig into the details? |
|
You can run the examples/shapes_and_collections/quad_bezier example under the qt5cairo (or some other foocairo) backend; it would fail as of master but succeed (same plot as fooagg) with this PR. |
timhoffm
approved these changes
Nov 17, 2018
jklymak
approved these changes
Nov 19, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 19, 2018
QuLogic
added a commit
that referenced
this pull request
Nov 27, 2018
…795-on-v3.0.x Backport PR #12795 on branch v3.0.x (Fix Bezier degree elevation formula in backend_cairo.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quad_bezier example would previously fail under the cairo backend;
this patch fixes it.
Closes #12794.
The broken implementation went in in 3.0 so milestoning as 3.0.x.
PR Summary
PR Checklist