Skip to content

MNT: fix logic error where we never try the second freetype URL #13451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2019
Merged

MNT: fix logic error where we never try the second freetype URL #13451

merged 1 commit into from
Feb 17, 2019

Conversation

tacaswell
Copy link
Member

closes #13450

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.0.3 milestone Feb 17, 2019
@tacaswell
Copy link
Member Author

Milestoning an 3.0.3 as 4de6dfb is is the PR to the 2.2.x branch and fixes the same bug.

@NelleV NelleV merged commit f5c88b4 into matplotlib:master Feb 17, 2019
@NelleV
Copy link
Member

NelleV commented Feb 17, 2019

Thanks @tacaswell !

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 17, 2019
@NelleV
Backport PR matplotlib#13451: MNT: fix logic error where we never try…
e2ff81f 
… the second freetype URL
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 17, 2019
Merged
@tacaswell tacaswell deleted the fix_cache_logic branch February 17, 2019 20:33
dstansby added a commit that referenced this pull request Feb 17, 2019
@dstansby
Merge pull request #13453 from meeseeksmachine/auto-backport-of-pr-13…
2ab4767 
…451-on-v3.0.x

Backport PR #13451 on branch v3.0.x (MNT: fix logic error where we never try the second freetype URL)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

Issues with jquery download caching
3 participants
@tacaswell @NelleV @timhoffm