Skip to content

More use of cbook._check_in_list. #13532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

More use of cbook._check_in_list. #13532

merged 1 commit into from
Feb 27, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 27, 2019

PR Summary

Missed these in #12232.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak
jklymak reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the value error raised by this change? The ones here seem pretty informative, and I don’t see how that is being preserved here...

@dstansby
Copy link
Member

I had a quick look, and I think the new ones are possibly more informative, because they include the list of acceptable strings (instead of just saying string x is bad)

@anntzer
Copy link
Contributor Author

anntzer commented Feb 27, 2019 •
edited
Loading

These all generate a standardized error message of the form "'foo' is not a valid value for bar; supported values are 'baz', 'quux'" (that's sort of the point of having this helper).

@timhoffm timhoffm merged commit b782eea into matplotlib:master Feb 27, 2019
@anntzer anntzer deleted the checkinlist branch February 27, 2019 16:55
@dstansby dstansby added this to the v3.2.0 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
API: argument checking
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @dstansby @jklymak @timhoffm @QuLogic