Search for fonts in XDG directory as well. #13766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently checks ~/.fonts, but not ~/.local/share/fonts, which fontconfig does do.
anntzer
approved these changes
Mar 26, 2019
timhoffm
reviewed
Mar 27, 2019
|
|
||
| # Precondition: the test font should not be available | ||
| fonts = findSystemFonts() | ||
| assert not any(font_test_file in font for font in fonts) |
There was a problem hiding this comment.
This is only to make sure that the test can run. It’s not part of the actual test condition. Shouldn‘t this better be a pytest.fail or pytest.skip?
There was a problem hiding this comment.
Hmm, possibly. I just copied this test from the one below.
There was a problem hiding this comment.
OK, I've added a skip if this condition isn't met.
timhoffm
approved these changes
Mar 30, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 30, 2019
dstansby
added a commit
that referenced
this pull request
Mar 30, 2019
…766-on-v3.1.x Backport PR #13766 on branch v3.1.x (Search for fonts in XDG directory as well.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It currently checks ~/.fonts, but not ~/.local/share/fonts, which fontconfig does do.
PR Checklist