Skip to content

Deprecate boxplot(..., whis="range"). #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Deprecate boxplot(..., whis="range"). #14360

merged 1 commit into from
May 30, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 28, 2019

It's a special-case that needs its own testing and documentation, when
it can be perfectly well folded into whis=(percentile, percentile)
(specifically, whis=(0, 100)).

Noted while reviewing #14358.

attn @phobson in can you think it's really worth keeping the special-cased API.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request May 28, 2019
Merged
@anntzer anntzer force-pushed the boxplot-whis branch 3 times, most recently from c1d09e4 to ff7591f Compare May 29, 2019 09:29
phobson
phobson approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together, @anntzer. I agree that the special case is unecessary and this is a welcome improvement from my POV.

@phobson
Copy link
Member

phobson commented May 29, 2019

(BTW, I can't parse the CircleCI failure)

@anntzer
Copy link
Contributor Author

anntzer commented May 29, 2019

looks like an unrelated failure to resolve references to dateutil in the docs due to problems with their online docs.

timhoffm
timhoffm reviewed May 30, 2019
View reviewed changes
@anntzer
Deprecate boxplot(..., whis="range").
a49cdbe 
It's a special-case that needs its own testing and documentation, when
it can be perfectly well folded into `whis=(percentile, percentile)`
(specifically, `whis=(0, 100)`).
@anntzer
Copy link
Contributor Author

anntzer commented May 30, 2019

thanks, all comments handled.

@timhoffm
Copy link
Member

+1 on the doc change +0.5 on the deprecation. Supporting four strings (three of which seem completely undocumented) as alternative to [0, 100] is insane. Generally, I would argue that a string is simpler to understand compared to whis=[0, 100], but I wouldn't know which one of these to keep, they all feel not quite right, too. So let's just remove them.

@timhoffm timhoffm merged commit b079233 into matplotlib:master May 30, 2019
@tacaswell tacaswell added this to the v3.2.0 milestone May 30, 2019
@anntzer anntzer deleted the boxplot-whis branch May 30, 2019 14:25
SimonRubenDrauz pushed a commit to SimonRubenDrauz/pandapower that referenced this pull request Oct 25, 2021
range in matplotlib boxplot is deprecated (matplotlib/matplotlib#14360)…
d58ee07 
…. Use the entire possible range instead.
@SimonRubenDrauz SimonRubenDrauz mentioned this pull request Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobson phobson phobson approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

@phobson phobson

Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @phobson @timhoffm @tacaswell