-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: return points rather than path to fix regression #14451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you reproduce the error in matplotlib somehow? I can’t really tell what the issue is from the astropy example. |
The problem is that we wanted to plot points rather than paths. This example from the issue in fact doesn't use astropy:
|
Great - I guess this is fine - if @anntzer had a reason for changing paths to points, I'm sure he'd have written a test to make sure we didn't re-break it on him 😛 But I actually suspect this was just a typo. I'm not 100% clear why this requires a projection to show up. A test would be very useful - if there was a way to make it not be an image test, even better, but sometimes those are unavoidable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I clearly typoed in #11407, sorry about that.
Is it possible to get the |
Merged to get the back ports going for 3.1.1, will open an issue to add tests. |
Thank you @bsipocz ! I am very happy that there is cross-project communication / collaboration going on (which to be fair has mostly been astropy telling Matplotlib we broke you ....). |
@tacaswell - I'm happy about the widening communication channels, too. I suppose it's a side effect of being upstream that we mostly report about breakage, but at least we start to run into them while testing against the dev version, even though this instance it wasn't the case. Also, I was looking into to add a test here, too, just haven't yet got to a point to identify what I could use in |
…451-on-v3.1.x Backport PR #14451 on branch v3.1.x (FIX: return points rather than path to fix regression)
…451-on-v2.2.x Backport PR #14451 on branch v2.2.x (FIX: return points rather than path to fix regression)
Regression in an astropy plotting example (astropy/astropy#8792) is due to #11407
Locally this PR fixes the issue and the test seem to be still working, but I didn't run the whole suite locally.
Please advise what kind of test is preferred to be added for this.