Skip to content

Fix bad missing-references.json due to PR merge race condition. #15015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix bad missing-references.json due to PR merge race condition. #15015

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 8, 2019

aka some missing references were fixed between the last build of the
nitpicky-mode PR and its merge.

fixes the broken doc build, so will selfmerge on pass

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Fix bad missing-references.json due to PR merge race condition.
bd459ba 
aka some missing references were fixed between the last build of the
nitpicky-mode PR and its merge.
@anntzer
Copy link
Contributor Author

anntzer commented Aug 9, 2019

@alexrudy I'm confused by the new missing refs re: Axes methods. Can you have a look?

@tacaswell tacaswell added this to the v3.2.0 milestone Aug 11, 2019
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Aug 11, 2019
Closed
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 11, 2019
@tacaswell tacaswell mentioned this pull request Aug 12, 2019
Merged
@ImportanceOfBeingErnest
Copy link
Member

Closing as superseeded by #15034

@anntzer anntzer deleted the fix-missing-refs branch August 12, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: duplicate
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @ImportanceOfBeingErnest @tacaswell @QuLogic