Skip to content

Fixes an error in the documentation of Ellipse #15486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

hannorein
Copy link
Contributor

PR Summary

This fixes a very minor error in the documentation of a function in the Ellipse class. The function returns the vertices of an ellipse, not a rectangle.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably it returns the path of the ellipse, not just the vertices?

@jklymak jklymak added this to the v3.1.2 milestone Oct 23, 2019
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jklymak
Copy link
Member

jklymak commented Oct 23, 2019

Thanks for your first PR! Please submit more!

@hannorein hannorein deleted the docufix branch October 23, 2019 15:23
timhoffm added a commit that referenced this pull request Oct 23, 2019
…486-on-v3.1.x

Backport PR #15486 on branch v3.1.x (Fixes an error in the documentation of Ellipse)
timhoffm added a commit that referenced this pull request Oct 23, 2019
…486-on-v3.2.x

Backport PR #15486 on branch v3.2.x (Fixes an error in the documentation of Ellipse)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants