Skip to content

FIX: do not consider webagg and nbagg "interactive" for fallback #15512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2019
Merged

FIX: do not consider webagg and nbagg "interactive" for fallback #15512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4ffb68
FIX: do not consider webagg and nbagg "interactive" for fallback
tacaswell Oct 25, 2019
0eaa2db
MNT: use set rather than list comprehension to filter backend list
tacaswell Oct 25, 2019
f6279ac
TST: correct webagg fallback behavior on headless machine
tacaswell Oct 28, 2019
8271e61
TST: try to fix windows by directly setting mplbackend env
tacaswell Oct 28, 2019
fd9f102
TST: skip the nbagg test if we don't have IPython installed
tacaswell Oct 31, 2019
557e56f
TST: fix sub process usage on windows
tacaswell Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/matplotlib/pyplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2244,7 +2244,8 @@ def getname_val(identifier):
# requested, ignore rcParams['backend'] and force selection of a backend that
# is compatible with the current running interactive framework.
if (rcParams["backend_fallback"]
and dict.__getitem__(rcParams, "backend") in _interactive_bk
and dict.__getitem__(rcParams, "backend") in (
set(_interactive_bk) - {'WebAgg', 'nbAgg'})
and cbook._get_running_interactive_framework()):
dict.__setitem__(rcParams, "backend", rcsetup._auto_backend_sentinel)
# Set up the backend.
Expand Down
28 changes: 28 additions & 0 deletions lib/matplotlib/tests/test_backend_webagg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import subprocess
import os
import sys
import pytest


@pytest.mark.parametrize("backend", ["webagg", "nbagg"])
def test_webagg_fallback(backend):
if backend == "nbagg":
pytest.importorskip("IPython")
env = {}
if os.name == "nt":
env = dict(os.environ)
else:
env = {"DISPLAY": ""}

env["MPLBACKEND"] = backend

test_code = (
"import os;"
+ f"assert os.environ['MPLBACKEND'] == '{backend}';"
+ "import matplotlib.pyplot as plt; "
+ "print(plt.get_backend());"
f"assert '{backend}' == plt.get_backend().lower();"
)
ret = subprocess.call([sys.executable, "-c", test_code], env=env)

assert ret == 0