Skip to content

Restore build_alllocal.cmd #15574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Restore build_alllocal.cmd #15574

wants to merge 3 commits into from

Conversation

story645
Copy link
Member

@story645 story645 commented Oct 30, 2019 •
edited
Loading

The building on windows using conda wheels instructions say to run build_alllocal.cmd which git history suggests may have accidentally been deleted?

(matplotlib_build) C:\Users\story\Projects\matplotlib>git log --full-history -1 -- build_alllocal.cmd
commit 4906876f57bafa8a242c18d75ddcf6033e5f7c61
Merge: ce334d46c 0bec9e623
Author: Thomas A Caswell <tcaswell@gmail.com>
Date:   Fri Oct 18 16:20:46 2019 -0400

    Merge pull request #15439 from jklymak/doc-mention-discourse

    DOC: mention discourse main page

commit 490687

I'm just adding the file back here in case it was accidental, otherwise this needs a doc fix that I don't know how to resolve.

ALso realizing now there's probably a git revert/cherry pick that's probably a better way of approaching this since it'll retain the file history.
xref w/ #15512 'cause that's how I ran into this.

@story645 story645 added the Build label Oct 30, 2019
anntzer
anntzer requested changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was made obsolete by #13077 (and even more by later files). Note that the latest docs do not mention it anymore: https://matplotlib.org/devdocs/users/installing.html#conda-packages.

@story645
Copy link
Member Author

Ugh, that probably should have been a commit message in the history explaining that...
And i think that's why I don't have #15476 which would have made this more obvious. 🤦‍♀️

Also this is really making me think about docs & versioning and making that stuff more obvious in some way.

@story645 story645 closed this Oct 30, 2019
@anntzer
Copy link
Contributor

anntzer commented Oct 31, 2019 •
edited
Loading

@story645 I think since #15476 was merged a Windows build from source (that includes that PR) should just need Visual Studio installed, and then pip install ./python setup.py ... should "just work". Please let me know if that's not the case.

@story645
Copy link
Member Author

Once I rebased against master to include that PR it does just work and now I have a working from source native windows build and thank you!

@story645 story645 deleted the build_all branch May 1, 2020 04:52
@story645 story645 restored the build_all branch May 1, 2020 04:52
@story645 story645 deleted the build_all branch June 8, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer requested changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@story645 @anntzer