Skip to content

Expire the _rename_parameters API changes. #16491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

Expire the _rename_parameters API changes. #16491

merged 1 commit into from
Feb 25, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 13, 2020

I put the changelog not under "removals", though they could possibly go
under "behavior changes" instead?

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Feb 13, 2020
jklymak
jklymak approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure seems real though...

@timhoffm
Copy link
Member

timhoffm commented Feb 16, 2020 •
edited
Loading

Sphinx has three warnings:

/usr/local/lib/python3.8/importlib/__init__.py:127: MatplotlibDeprecationWarning: 
The mpl_toolkits.axes_grid1.colorbar module was deprecated in Matplotlib 3.2 and will be removed two minor releases later. Use matplotlib.colorbar instead.

reading sources... [ 12%] api/_as_gen/matplotlib.axes.Axes.secondary_xaxis
<string>:6: RuntimeWarning: divide by zero encountered in true_divide

/home/circleci/project/doc/api/next_api_changes/removals.rst:150: WARNING: py:obj reference target not found: bezier

of which i think only the last one really counts for the failure (build finished with problems, 1 warning.)

@timhoffm timhoffm mentioned this pull request Feb 16, 2020
Closed
@anntzer
Copy link
Contributor Author

anntzer commented Feb 16, 2020 •
edited
Loading

Added an api entry for matplotlib.bezier to resolve the missing ref.
edit: ... which meant fixing some markup in that module as well.

@anntzer
Expire the _rename_parameters API changes.
6e0b093 
I put the changelog not under "removals", though they could possibly go
under "behavior changes" instead?
@story645 story645 merged commit dc1f0d9 into matplotlib:master Feb 25, 2020
@anntzer anntzer deleted the rename_parameters branch February 25, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @story645 @jklymak