Skip to content

Fix typo in implementation of quit_all_keys. #16907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix typo in implementation of quit_all_keys. #16907

merged 1 commit into from
Mar 26, 2020
+1 −1

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 25, 2020

The wrong lookup caused "q" to incorrectly close all windows.

missed this reviewing #16863

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Fix typo in implementation of quit_all_keys.
93a160f 
The wrong lookup caused "q" to incorrectly close all windows.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 25, 2020
@anntzer anntzer added this to the v3.3.0 milestone Mar 25, 2020
@timhoffm
Copy link
Member

Oops! Thanks for finding this!

@QuLogic QuLogic merged commit d5f3e26 into matplotlib:master Mar 26, 2020
@anntzer anntzer deleted the qak branch March 26, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic