Keep cachedRenderer as None when pickling Figure. #17705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Figure.__init__` sets cachedRenderer to None, so it's awkward that pickling and unpickling a figure completely removes the attribute, causing obscure AttributeErrors.
timhoffm
approved these changes
Jun 21, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 22, 2020
tacaswell
added a commit
that referenced
this pull request
Jun 22, 2020
…705-on-v3.3.x Backport PR #17705 on branch v3.3.x (Keep cachedRenderer as None when pickling Figure.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figure.__init__sets cachedRenderer to None, so it's awkward thatpickling and unpickling a figure completely removes the attribute,
causing obscure AttributeErrors.
Closes #17627. (Well, I can't actually repro the issue as reported -- I suspect it has something to do with interagg, i.e. pycharm -- but this should certainly get rid of the AttributeError.)
PR Summary
PR Checklist