MNT: do a better job guessing the GUI framework in use #18245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Aug 13, 2020
We currently check the GUI framework and reject changing to a different framework. This adds the ability to check the running framework before we start guessing frameworks to use.
b20355d to
448779a
Compare
timhoffm
approved these changes
Aug 13, 2020
jkseppan
approved these changes
Aug 14, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
jkseppan
added a commit
to jkseppan/matplotlib
that referenced
this pull request
Aug 14, 2020
…ramework in use
dopplershift
added a commit
that referenced
this pull request
Aug 14, 2020
…v3.3.x Backport PR #18245 on branch v3.3.x
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We currently check the GUI framework and reject changing to
a different framework. This adds the ability to check the running
framework before we start guessing frameworks to use.
This matters the most in the headless linux case where you have a lot of the GUI frameworks available. Currently we try to import all of them before we give up (despite the fact that it is check on our side that is failing them!)
PR Checklist