Skip to content

Make Colorbar outline into a Spine. #18320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2020
Merged

Make Colorbar outline into a Spine. #18320

merged 1 commit into from
Aug 22, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 22, 2020

PR Summary

This moves its draw to after all artists, which is consistent with normal Axes frames.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.4.0 milestone Aug 22, 2020
@QuLogic
Make Colorbar outline into a Spine.
16fad26 
This moves its draw to after all artists, which is consistent with
normal Axes frames.
@dstansby dstansby merged commit c5d15fc into matplotlib:master Aug 22, 2020
@QuLogic QuLogic deleted the colorbar-outline branch August 24, 2020 19:35
@QuLogic QuLogic mentioned this pull request Aug 25, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: color/colorbar
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @dopplershift @dstansby