Warn if an animation is gc'd before doing anything. #18445

QuLogic · 2020-09-10T07:47:10Z

PR Summary

Wording may be a bit terse, feel free to make suggestions.

Fixes #18438.

Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant (run flake8 on changed files to check).
[n/a] New features are documented, with examples if plot related.
[n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
[n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
[n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

lib/matplotlib/animation.py

tacaswell

Modulo @timhoffm 's suggestions.

lib/matplotlib/tests/test_animation.py

QuLogic added the topic: animation label Sep 10, 2020

QuLogic added this to the v3.4.0 milestone Sep 10, 2020

timhoffm reviewed Sep 10, 2020

View reviewed changes

lib/matplotlib/animation.py Outdated Show resolved Hide resolved

lib/matplotlib/animation.py Outdated Show resolved Hide resolved

tacaswell approved these changes Sep 11, 2020

View reviewed changes

QuLogic force-pushed the warn-gc-anim branch from 4a9ade0 to ce9c80a Compare September 11, 2020 03:37

timhoffm approved these changes Sep 11, 2020

View reviewed changes

timhoffm reviewed Sep 11, 2020

View reviewed changes

lib/matplotlib/tests/test_animation.py Outdated Show resolved Hide resolved

Warn if an animation is gc'd before doing anything.

9cf0c09

Fixes matplotlib#18438.

QuLogic force-pushed the warn-gc-anim branch from ce9c80a to 9cf0c09 Compare September 11, 2020 21:48

timhoffm merged commit f65d47e into matplotlib:master Sep 11, 2020

QuLogic deleted the warn-gc-anim branch September 11, 2020 23:41