Use data to set default limits when appropriate #18803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggest just get rid of the hard code date limits as we now have a variable epoch and default 0-1 is fine. |
|
I attempted to remove the hard coded date limits by setting |
|
Thanks for working on this, but I'll close as not being quite right either! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #7742
This is the third attempt at solving #7742. The first two attempts, #8210 and #18771, made use of
ignore_existing_data_limits, but this attribute will be deprecated as discussed in #17106.The difficulty with date-like data is the hard-code default limits of (2000, 2010). So, this approach modifies
set_default_intervalsto use the actual data instead of these hard-coded values when appropriate.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).